Wizard theme locale overrides no longer work

Hi @fzngagan @angus - unfortunately this regression is blocking us from deploying the latest wizard.

Environment

Discourse Version: 2.7.0.beta1 0034cbda8a

Plugin Commit: 94a02157af640e534066f11d143e5fd7af924fc0

Other Plugins

Steps to Reproduce

  1. Create a theme with a locale override

locales/en.yml

en:
  wizard:
    done: Hello!

Add this to a new wizard. Observe that the Done button is not overwritten.

Note: This worked as recently as wizard commit 0960dda, so is a regression.

Example

Logs

1 Like

Will take a look tomorrow.

@othomson
I did investigate it. Here’s the issue and a PR for the fix.

I think discourse behaviour around themes has recently changed, which caused the header templates to stop working too.

2 Likes

Thanks!

Merged.

Looks good to me, thanks!

Quick question - is it possible to override server locales with this system? Specifically:

field:
      too_short: "%{label} must be at least %{min} characters"
      too_long: "%{label} must not be more than %{max} characters"

I suspect not - but figured it was worth an ask.

1 Like

No they cant be. :slight_smile:

1 Like

@othomson
I hope this is working fine for you now. :slight_smile:

1 Like