Can you push what you’ve already done to a branch and make a PR, it’ll make it easier for me to work-in with you.
sure. In a moment.
I’ve made a PR.
Great, I’m taking a look.
This seems to be working for me. Can you try stopping your server and removing your tmp file? i.e. rm -rf tmp.
Are you able to change back to default?
Ah indeed. I think I see the issue. That field isn’t being cast as a boolean, so the string “false” is being interpreted as truthy.
I’m testing this currently.
Yup, the cast is the issue. I’ve commited that fix and will now merge the PR. Good work
Ok, here’s a test in production:
Looks like you’re good to go with the announcement
Thanks for confirming. I’ve announced the fix.
No, I think there’s at least one more ‘custom_field’ scope bug but it’s less critical. I’ll address in a spare hour this week.
I read your post on meta?
Did we have to actually change the way data is serialized for any of our plugins?
Maybe I’m missing something…
Ok, I think I missed the point of it. There was a backend change which forced us to make the frontend changes we did.
Yeah, essentially. You’re right that we technically didn’t change anything on the backend, but we’re effectively changing the way we serialize data because of the issue with add_to_serializer.
first things first: Thank you so much for your work on these fine plugins within the Discourse ecosystem.
We are running 2.4.0.beta7 on both https://community.hiveeyes.org/ and https://community.panodata.org/ and it looks like we’ve been hit by this obstacle again on the latter while everything is fine on the former.
The main difference is that the Events Plugin has been installed on Hiveeyes for quite some time and we just installed it on Panodata.
We tried hard to replicate every setting to the Panodata instance, but no matter what, the “Add Event” button just won’t show up.
However, we can confirm the plugin seems to be active on the respective category as enabling the All topics in this category must have an event. option actually works: By not being able to actually fill in an event, this well prevents adding new topics to the category.
The notification popup coming up just verified on Hiveeyes
also doesn’t show up in this case. It just rejects the submission silently.
So, we figure the UI elements just won’t get activated for some reason.
Thanks already for looking into this.
With kind regards,
Can you try disabling and re-enabling the plugin?
To be safe on that detail, I disabled the plugin both on the global and the category level [1,2] and it started working right away .
That was easy, now I am feeling a bit silly. Thank you so much!
With kind regards,
This has been the solution for atleast two other cases…I think it has something to do with some recent change in discourse… I’ll need to do some digging to isolate the exact cause of this…